Cloudformation support for Secrets Manager Integration #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkondru
approved these changes
Dec 19, 2023
mashuaihh
reviewed
Dec 19, 2023
| @@ -207,7 +207,7 @@ protected boolean issueModifyClusterMaintenanceRequest(ResourceModel model) { | |||
| // check for required parameters to not have null values | |||
| protected boolean invalidCreateClusterRequest(ResourceModel model) { | |||
| return model.getClusterIdentifier() == null || model.getNodeType() == null | |||
| || model.getMasterUsername() == null || model.getMasterUserPassword() == null; | |||
| || model.getMasterUsername() == null; | |||
There was a problem hiding this comment.
if cx doesn't pass in ManageMasterPassword the request would still be invalid right, can we add the condition for all the scenarios here please? or tell me I'm wrong :)
- Check if required parameters are provided - ClusterIdentifier, NodeType, MasterUsername - Check if either MasterUserPassword is provided or ManageMasterPassword is true
mashuaihh
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes provide Cloudformation support for Secrets Manager integration with Redshift clusters. With this new feature, customers can opt in to store their cluster's admin credentials in a service linked secret in Secrets Manager. It allows us to create/modify/restore Redshift clusters with Secrets Manager support using the Cloudformation template. The changes in this request allow us to use create-cluster, modify-cluster, restore-from-cluster-snapshot APIs for Redshift clusters when opting in to this feature.
We are adding a new boolean parameter "ManageMasterPassword" to allow customers to opt in to this feature and another parameter "MasterPasswordSecretKmsKeyId" allows customers to specify the key ID of the KMS key in the customer account which will be used to encrypt the cluster secret. These parameters can be used while setting CreateClusterRequest, ModifyClusterRequest and RestoreFromClusterSnapshotRequest. The response of these requests will return the "MasterPasswordSecretArn" when the cluster is opted in to this feature.