AWS::Serverless::Api resource throws Obsolete DependsOn

[ben-elsen]

cfn-lint version: 0.31.1

Description of issue.
I have a AWS::Serverless::Api resource that is formatted like the documentation (https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-resource-api.html & https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-api-apiusageplan.html#sam-property-api-apiusageplan--examples) and everything deploys well to AWS but the linter gives an error:

[Serverless IDE] W3005: Obsolete DependsOn on resource (ApiGateway), dependency already enforced by a "Ref" at Resources/ApiGatewayUsagePlan/Properties/ApiStages/0/ApiId/Ref

The template is:

  #############################################################
  # The api config
  ############################################################
  ApiGateway:
    Type: AWS::Serverless::Api
    Properties:
      StageName: !Ref StageName
      Auth:
        ApiKeyRequired: true
        UsagePlan:
          CreateUsagePlan: PER_API
          Description: Usage plan for this API
          Quota:
            Limit: 500
            Period: MONTH
          Throttle:
            BurstLimit: 100
            RateLimit: 50```

[PatMyron]

Thanks for the template and warning message. We've had quite a few recent similar issues with code generated by the AWS::Serverless transform failing rules:
#1265
#1522

Raising an issue in their repository and/or ignoring with something like --ignore-checks W3005 is probably the best advice I have for now unfortunately

[ben-elsen]

Hi @PatMyron,
Thanks for the advice!