Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node 22 lts, #fixes 3837 #3841

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

JamesKyburz
Copy link
Contributor

Issue #3837

Description of changes:

Add Node 22 validation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BigButovskyi
Copy link

thats is really good work, thx @JamesKyburz 👍

@r-heimann
Copy link

r-heimann commented Nov 26, 2024

Aren't schema updates pulled through the bot? #3832

Might be the case that @kddejong is busy with reinvent stuff and wasn't able to release an updated cfn-lint yet. You should be able to use cfn-lint --update-specs to update the cfn-lint schemas and it should find the new nodejs lambda support.

@JamesKyburz
Copy link
Contributor Author

@r-heimann It only worked for we with the changes in this pr, running cfn-lint --update-specs did pull down the latest schema changes but still didn't validate against Node 22.

@kddejong
Copy link
Contributor

We have automation jobs that do a lot of the work for these values. #3832 picked up the new value.

@kddejong
Copy link
Contributor

It can be hard to understand if the value came from boto, the schema, AWS APIs, pricing data, or manually. May have to work on adding a field to the schema so its easier to understand this.

@kddejong kddejong merged commit 7af0ad6 into aws-cloudformation:main Nov 26, 2024
22 checks passed
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (d2ca335) to head (261c91d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
- Coverage   93.78%   93.78%   -0.01%     
==========================================
  Files         364      364              
  Lines       12460    12460              
  Branches     2554     2554              
==========================================
- Hits        11686    11685       -1     
  Misses        429      429              
- Partials      345      346       +1     
Flag Coverage Δ
unittests 93.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants