Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::EKS::Cluster ClusterLogging #208

Closed
ueokande opened this issue Oct 8, 2019 · 4 comments
Closed

AWS::EKS::Cluster ClusterLogging #208

ueokande opened this issue Oct 8, 2019 · 4 comments
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Milestone

Comments

@ueokande
Copy link

ueokande commented Oct 8, 2019

1. Title

AWS::EKS::Cluster ClusterLogging

2. Scope of request

c) new attribute for an existing resource is desired

3. Expected behavior

Allow users to manage cluster logging on EKS cluster via CloudFormation.

Currently, the cluster logging is disabled on EKS by default. The EKS officially supports via API, but CloudFormation doesn't. CloudFormation should also supports managements of the clouster logging.

The type of the cluster loggings are "api", "audit", "authenticator", "controllerManager" and "scheduler". The API can enable or disable such types of logging. The resource template should be able to enable and disable certain log types.

The stack template is described in declarative format. The given types of the logging will be enabled by Cfn, and non-given types will be disabled on updating the stack. Here is an example:

MyEksCluster:
  Type: "AWS::EKS::Cluster"
  Properties:
    # Enable "api", "audit", and "authenticator" logging
    ClusterLoggingEnabled:
      - "api"
      - "audit"
      - "authenticator"

If the ClusterLoggingEnabled field is missing or empty, no types are enabled.

4. Suggest specific test cases

Create a stack with AWS::EKS::Cluster and ClusterLoggingEnabled field, the stack creates EKS cluster configured cluster logging. On updating a stack with ClusterLoggingEnabled, given log types are enabled and missing log types are disabled.

If the ClusterLoggingEnabled field is not given, all of log types are disabled.

5. Helpful Links to speed up research and evaluation

API Document of cluster logging on EKS:
https://docs.aws.amazon.com/eks/latest/APIReference/API_Logging.html
https://docs.aws.amazon.com/eks/latest/APIReference/API_LogSetup.html

6. Category (required) - Will help with tagging and be easier to find by other users to +1

Compute ( EKS )

7. Any additional context (optional)

@TheDanBlanco TheDanBlanco added the compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository label Oct 9, 2019
@whereisaaron
Copy link

eksctl-io/eksctl#778

@lynnnnnnluo
Copy link

lynnnnnnluo commented Aug 20, 2021

We are working on the feature.

@cfn-github-issues-bot cfn-github-issues-bot moved this from Researching to Shipped in coverage-roadmap Aug 20, 2021
@rohits-spec rohits-spec reopened this Aug 20, 2021
@cfn-github-issues-bot cfn-github-issues-bot moved this from Shipped to We're working on it in coverage-roadmap Aug 20, 2021
@cfn-github-issues-bot cfn-github-issues-bot moved this from We're working on it to Researching in coverage-roadmap Nov 11, 2021
@gabegorelick
Copy link

@cfn-github-issues-bot cfn-github-issues-bot moved this from Researching to Shipped in coverage-roadmap Nov 12, 2021
@lynnnnnnluo
Copy link

This feature is now available using the EKS cluster CFN resource

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-cluster.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Projects
coverage-roadmap
  
Shipped
Development

No branches or pull requests

8 participants