Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecs] AlarmNames should be optional #2087

Open
axot opened this issue Jun 13, 2024 · 0 comments
Open

[ecs] AlarmNames should be optional #2087

axot opened this issue Jun 13, 2024 · 0 comments
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. service/ecs Indicates issues or PRs that are related to ecs-controller.

Comments

@axot
Copy link

axot commented Jun 13, 2024

Describe the bug
When updating service.ecs.services.k8s.aws, the controller shows the following error

"error": "InvalidParameter: 1 validation error(s) found.\n- missing required field, UpdateServiceInput.DeploymentConfiguration.Alarms.AlarmNames.\n",

Steps to reproduce

  1. import exists ecs service
  2. edit service's desiredCount

an example AdoptedResource

apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
  name: hello
  namespace: hello
spec:
  aws:
    nameOrID: hello
    additionalKeys:
      cluster: cluster-hello
  kubernetes:
    group: ecs.services.k8s.aws
    kind: Service

Expected outcome
No error when applying service

Environment
EKS

  • Kubernetes version 1.29
  • Using EKS (yes/no), if so version? yes, 1.29
  • AWS service targeted (S3, RDS, etc.) ecs
@a-hilaly a-hilaly added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. service/ecs Indicates issues or PRs that are related to ecs-controller. labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. service/ecs Indicates issues or PRs that are related to ecs-controller.
Projects
None yet
Development

No branches or pull requests

2 participants