Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'metadata.labels' as Tags for all controllers #2091

Open
max-rocket-internet opened this issue Jun 17, 2024 · 0 comments
Open

Use 'metadata.labels' as Tags for all controllers #2091

max-rocket-internet opened this issue Jun 17, 2024 · 0 comments
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/feature Categorizes issue or PR as related to a new feature. service/all Indicates issues or PRs related to all the service controllers.

Comments

@max-rocket-internet
Copy link

max-rocket-internet commented Jun 17, 2024

Is your feature request related to a problem?

We write an abstraction for ACK resources and I'm looking for an easy and consistent way of specifying and testing tags for ACK resources.

The current process for adding tags to resources is quite mixed. So far I've found 4 different approaches:

  1. spec.tags is []*Tag: most common across all controllers, e.g. SNS
  2. spec.tags is []*Tag but different: The key/value names are different for KMS
  3. spec.tags is map[string]*string: for SQS controller
  4. spec.tagging.tagSet is []*Tag: for S3 controller

Describe the solution you'd like

Can we just copy GCP Config Connector?

Labels in the metadata field of a Config Connector resource are also added to the associated Google Cloud resource.

It would be super convenient and nice if labels from the ACK custom resource are just copied from metadata.labels to the cloud resource that is created by the ACK controller.

Describe alternatives you've considered

Currently we just deal with the inconsistency in our abstraction layer but it feels messy.

@a-hilaly a-hilaly added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/feature Categorizes issue or PR as related to a new feature. service/all Indicates issues or PRs related to all the service controllers. and removed kind/enhancement Categorizes issue or PR as related to existing feature enhancements. labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/feature Categorizes issue or PR as related to a new feature. service/all Indicates issues or PRs related to all the service controllers.
Projects
None yet
Development

No branches or pull requests

2 participants