Use 'metadata.labels' as Tags for all controllers #2091
Labels
area/runtime
Issues or PRs as related to controller runtime, common reconciliation logic, etc
kind/feature
Categorizes issue or PR as related to a new feature.
service/all
Indicates issues or PRs related to all the service controllers.
Is your feature request related to a problem?
We write an abstraction for ACK resources and I'm looking for an easy and consistent way of specifying and testing tags for ACK resources.
The current process for adding tags to resources is quite mixed. So far I've found 4 different approaches:
spec.tags
is[]*Tag
: most common across all controllers, e.g. SNSspec.tags
is[]*Tag
but different: The key/value names are different for KMSspec.tags
ismap[string]*string
: for SQS controllerspec.tagging.tagSet
is[]*Tag
: for S3 controllerDescribe the solution you'd like
Can we just copy GCP Config Connector?
It would be super convenient and nice if labels from the ACK custom resource are just copied from
metadata.labels
to the cloud resource that is created by the ACK controller.Describe alternatives you've considered
Currently we just deal with the inconsistency in our abstraction layer but it feels messy.
The text was updated successfully, but these errors were encountered: