Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations don't update from AdoptedResource to the child resource #2104

Open
PowerSurj opened this issue Jun 28, 2024 · 0 comments
Open

Annotations don't update from AdoptedResource to the child resource #2104

PowerSurj opened this issue Jun 28, 2024 · 0 comments
Labels
area/adopted-resource Issues or PRs related to ACK Adopted Resources area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements.

Comments

@PowerSurj
Copy link

PowerSurj commented Jun 28, 2024

Describe the bug

I deployed an AdoptedResource for prometheusservice Workspace without an annotation first.
Resource got successfully adopted and the Workspace custom resource got created.

Then I added an annotation in the metadata of the resource spec in the AdoptedResource.

spec:
  aws:
    nameOrID: ws-11111
  kubernetes:
    group: prometheusservice.services.k8s.aws
    kind: Workspace
    metadata:
      annotations:
        services.k8s.aws/deletion-policy: retain
      name: myworkspace
      namespace: mynamespace

However this annotation never got added to the Workspace resource.

Noticed that annotations only get set when you deploy a new resource, though.

Expected outcome

Annotations should've been set / updated on the Workspace / managed resource.

Environment

EKS 1.29
prometheusservice-controller:1.2.9

@a-hilaly a-hilaly added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc area/adopted-resource Issues or PRs related to ACK Adopted Resources labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/adopted-resource Issues or PRs related to ACK Adopted Resources area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants