Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added getting-started documentation for quickstart with Simple Build Pipeline #177

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

henrykie
Copy link
Contributor

@henrykie henrykie commented Aug 5, 2024

Issue number:

Summary

Adding a Getting Started documentation page for step-by-step instructions for deploying the Simple Build Pipeline.

Changes

Please provide a summary of what's being changed

New documentation.

User experience

Please share what the user experience looks like before and after this change

Getting Started page will serve as entry point for quickstart.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change? No.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@henrykie henrykie requested a review from a team as a code owner August 5, 2024 21:38
@henrykie henrykie requested a review from squidbot August 5, 2024 21:38
@henrykie henrykie self-assigned this Aug 5, 2024
@henrykie henrykie added documentation Improvements or additions to documentation samples Updates to project samples initial launch (v1.0.0-alpha) initial launch labels Aug 5, 2024
@henrykie henrykie added this to the v1.0.0-alpha milestone Aug 5, 2024
@kylesomers
Copy link
Member

On assets/index.html there are broken links to jenkins and ansible asset pages.

Copy link
Member

@kylesomers kylesomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes inline.

docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/assets/jenkins-pipelines.md Outdated Show resolved Hide resolved
docs/modules/jenkins/jenkins.md Outdated Show resolved Hide resolved
- Broken links on /docs/assets/index.md fixed
- Notes autoexpanded in getting-started.md
@henrykie henrykie changed the title feat: Added getting-started documentation for quickstart with _Simple_Build_Pipeline feat: Added getting-started documentation for quickstart with Simple Build Pipeline Aug 6, 2024
@henrykie henrykie requested review from kylesomers and removed request for squidbot August 6, 2024 23:24
kylesomers
kylesomers previously approved these changes Aug 6, 2024
@henrykie henrykie requested a review from kylesomers August 6, 2024 23:31
@kylesomers kylesomers merged commit 4710f8e into main Aug 6, 2024
6 checks passed
@henrykie henrykie deleted the henrykie/docs branch August 9, 2024 15:02
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
…Build Pipeline (aws-games#177)

Co-authored-by: Kyle Somers <17753062+kylesomers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation initial launch (v1.0.0-alpha) initial launch samples Updates to project samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants