Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for cloud-init to complete prior to installing packages during Perforce Helix Core AMI creation #193

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jorisdon
Copy link
Contributor

Issue number: #192

Summary

Changes

Prior to installing packages, the install script now waits for cloud-init to complete

User experience

No changes to user experience

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

(no documentation changes necessary)

Is this a breaking change? No

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@jorisdon jorisdon requested a review from a team as a code owner August 14, 2024 12:44
@jorisdon jorisdon requested a review from novekm August 14, 2024 12:44
@jorisdon jorisdon added bug Something isn't working packer Work related to Packer templates perforce labels Aug 14, 2024
@henrykie
Copy link
Contributor

@jorisdon We require signed commits. Can you set up a GPG key and amend a signature on this commit?

@kylesomers kylesomers added this to the v1.0.1-alpha milestone Aug 14, 2024
@jorisdon
Copy link
Contributor Author

@jorisdon We require signed commits. Can you set up a GPG key and amend a signature on this commit?

Thanks; fixed.

@jorisdon jorisdon merged commit fa1741c into main Aug 15, 2024
4 checks passed
@jorisdon jorisdon deleted the jorisdon/fix-192 branch August 15, 2024 11:19
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packer Work related to Packer templates perforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants