Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjusting changelog automation to leverage GH api #266

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

henrykie
Copy link
Contributor

Issue number:

Summary

Adjusted changelog automation to leverage GH API for signed commits.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
Is this a breaking change?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.

@henrykie henrykie requested a review from a team as a code owner September 13, 2024 17:52
@henrykie henrykie requested a review from squidbot September 13, 2024 17:52
@kylesomers kylesomers requested review from kylesomers and removed request for squidbot September 13, 2024 20:30
@kylesomers kylesomers changed the title Adjusting changelog automation to leverage GH api chore: adjusting changelog automation to leverage GH api Sep 13, 2024
Copy link
Member

@kylesomers kylesomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Checkov failures are not critical and are incorrectly flagging unchanged files (will fix). CKV_AWS_184 will be addressed with suppression rule since we don't want to force usage of CMKs with modules, and CKV_GH_7 can be suppressed since we run manual docs release workflow with versioning inputs required for our use of mike utility.

@kylesomers kylesomers merged commit 7b6730b into main Sep 13, 2024
6 of 7 checks passed
@kylesomers kylesomers deleted the fix/changelog branch September 13, 2024 20:37
jcwolfaws pushed a commit to jcwolfaws/cloud-game-development-toolkit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants