Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure conditional creation applies to data sources #21

Merged
merged 1 commit into from
Sep 23, 2023
Merged

fix: Ensure conditional creation applies to data sources #21

merged 1 commit into from
Sep 23, 2023

Conversation

bryantbiggs
Copy link
Collaborator

What does this PR do?

  • Ensure conditional creation applies to data sources
    • Data sources are used for IRSA so if not creating the module nor creating IRSA, do not call the data sources
  • Do not create a custom policy for IRSA if no values have been provided for the custom policy
  • Remove the use of the defunct kubectl provider
  • Upgrade example to latest module versions and EKS version

Motivation

Test Results

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner September 23, 2023 14:54
askulkarni2
askulkarni2 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bryantbiggs bryantbiggs merged commit 327207a into main Sep 23, 2023
6 checks passed
@bryantbiggs bryantbiggs deleted the fix/conditional-create branch September 23, 2023 19:58
@bryantbiggs bryantbiggs mentioned this pull request Sep 23, 2023
Merged
3 tasks
williamsbobby1423 pushed a commit to williamsbobby1423/terraform-aws-eks-blueprints-addon that referenced this pull request Sep 25, 2023
@bryantbiggs @williamsbobby1423
fix: Ensure conditional creation applies to data sources (aws-ia#21)
a1ccba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: aws_caller_identity and aws_partition allocated, even if var.create is false
2 participants
@bryantbiggs @askulkarni2