fix: Fixed permissions for fluentbit #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
commented
May 16, 2023
| @@ -515,7 +516,7 @@ data "aws_iam_policy_document" "aws_for_fluentbit" { | |||
| sid = "PutLogEvents" | |||
| effect = "Allow" | |||
| resources = [ | |||
| "arn:${local.partition}:logs:${local.region}:${local.account_id}:log-group:${try(var.aws_for_fluentbit_cw_log_group.name, "*")}:log-stream:*", | |||
| "arn:${local.partition}:logs:${local.region}:${local.account_id}:log-group:${try(var.aws_for_fluentbit_cw_log_group.name, "")}*:log-stream:*", | |||
There was a problem hiding this comment.
to support log group with prefix as well
vara-bonthu
commented
May 16, 2023
| @@ -527,7 +528,7 @@ data "aws_iam_policy_document" "aws_for_fluentbit" { | |||
| sid = "CreateCWLogs" | |||
| effect = "Allow" | |||
| resources = [ | |||
| "arn:${local.partition}:logs:${local.region}:${local.account_id}:log-group:${try(var.aws_for_fluentbit_cw_log_group.name, "*")}", | |||
| "arn:${local.partition}:logs:${local.region}:${local.account_id}:log-group:${try(var.aws_for_fluentbit_cw_log_group.name, "")}*", | |||
There was a problem hiding this comment.
to support log group with prefix as well
bryantbiggs
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
1/ Fixes the FluentBit IAM policy issue for cloudwatch log group with prefix
2/ Fixes the handling of CW Group name and prefix
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes