-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Override karpenter instance profile name #325
fix: Override karpenter instance profile name #325
Conversation
There is a pre-existing variable in `karpenter` which can override the instance profile name, but it's only applied for the Helm chart. For the instance profile name itself it's not used. We use `instance_profile_name` as a default, and only if it is not set `local.karpenter_node_iam_role_name` is instead used.
This PR has been automatically marked as stale because it has been open 30 days |
Any opinions on this PR @csantanapr @bryantbiggs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM, @bryantbiggs could you double check?
…vs output (the name of the profile created or existing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarified the names a bit since there are two different use cases - the name passed to the instance profile the module creates, and the name passed to the Helm chart for Karpenter to use
What does this PR do?
There is a pre-existing variable in
karpenter
which can override the instance profile name, but it's only applied for the Helm chart. For the instance profile name itself it's not used. Here we change the name to instead useinstance_profile_name
as a default, and only if it is not set thenlocal.karpenter_node_iam_role_name
is used.Motivation
We have a pre-existing Karpenter setup (in Argo CD) which assumes a different instance profile name than the one being set.
More
pre-commit run -a
with this PRFor Moderators
Additional Notes