fix: Override karpenter instance profile name #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a pre-existing variable in `karpenter` which can override the instance profile name, but it's only applied for the Helm chart. For the instance profile name itself it's not used. We use `instance_profile_name` as a default, and only if it is not set `local.karpenter_node_iam_role_name` is instead used.
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Any opinions on this PR @csantanapr @bryantbiggs? |
csantanapr
reviewed
Feb 1, 2024
…vs output (the name of the profile created or existing)
bryantbiggs
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is a pre-existing variable in
karpenterwhich can override the instance profile name, but it's only applied for the Helm chart. For the instance profile name itself it's not used. Here we change the name to instead useinstance_profile_nameas a default, and only if it is not set thenlocal.karpenter_node_iam_role_nameis used.Motivation
We have a pre-existing Karpenter setup (in Argo CD) which assumes a different instance profile name than the one being set.
More
pre-commit run -awith this PRFor Moderators
Additional Notes