feat(external-dns): Add zone-id filters by default when external_dns_route53_zone_arns is defined
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egarbi
force-pushed
the
use-external_dns_route53_zone_arns-as-filter
branch
from
73da201
to
601c80a
Compare
egarbi
force-pushed
the
use-external_dns_route53_zone_arns-as-filter
branch
from
601c80a
to
e60e695
Compare
100% of users passing ARN(s) in external_dns_route53_zone_arns will benefit of this feature. - Enhance reliability when adding records to specific zones. - Prevent "Access Denied" errors by aligning zone retrieval with the intended zone for record addition. - Reducen AWS Route 53 API calls, minimizing the risk of rate-limiting.
egarbi
force-pushed
the
use-external_dns_route53_zone_arns-as-filter
branch
from
e60e695
to
9f75c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a feature to pass zone IDs as filters to external-dns. filters are parsed from
external_dns_route53_zone_arnsMotivation
100% of users passing ARN(s) in external_dns_route53_zone_arns will benefit of this feature.
external_dns_route53_zone_arnsaszone-id-filter#333More
pre-commit run -awith this PRFor Moderators
Additional Notes
I know anyone can add this by passing the values to Helm in a variable. But having the module doing it by default is convenient and I cannot think of any use case for not doing this.