Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct spelling in the locals.ec2_events #344

Closed
wants to merge 6 commits into from
Closed

fix: Correct spelling in the locals.ec2_events #344

wants to merge 6 commits into from

Conversation

KAZYPinkSaurus
Copy link

@KAZYPinkSaurus KAZYPinkSaurus commented Jan 23, 2024

What does this PR do?

I will make corrections to find spelling mistakes.
I understand that this change only affects the identifiers of resources.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
~/terraform-aws-eks-blueprints-addons$ pre-commit run -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
detect private key.......................................................Passed
detect aws credentials...................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

The corrected word affects only resource id.

I confirmed the correct spelling.

$ terraform plan | grep "spot_interrupt"
  # aws_cloudwatch_event_rule.karpenter["spot_interrupt"] will be created
  # aws_cloudwatch_event_target.karpenter["spot_interrupt"] will be created

neelaruban and others added 5 commits December 7, 2023 13:59
…required resources (#329)

Co-authored-by: ruban suthan <ruban.suthanthiraraj@rackspace.com>
…d logs to Kinesis Data Firehose (#310)

Co-authored-by: Vinasirajan Vilakshan <v.vinasirajan@gtngroup.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
@KAZYPinkSaurus KAZYPinkSaurus changed the title fix spelling fix: spelling Jan 23, 2024
@KAZYPinkSaurus KAZYPinkSaurus changed the title fix: spelling fix: Correct spelling Jan 23, 2024
@KAZYPinkSaurus KAZYPinkSaurus changed the title fix: Correct spelling fix: Correct spelling in the local.ec2_events Jan 23, 2024
@KAZYPinkSaurus KAZYPinkSaurus changed the title fix: Correct spelling in the local.ec2_events fix: Correct spelling in the locals.ec2_events Jan 23, 2024
@KAZYPinkSaurus KAZYPinkSaurus marked this pull request as ready for review January 23, 2024 13:48
@KAZYPinkSaurus KAZYPinkSaurus requested a review from a team as a code owner January 23, 2024 13:48
@bryantbiggs bryantbiggs changed the base branch from main to v2.0 January 23, 2024 23:01
@bryantbiggs
Copy link
Contributor

this would be a breaking change so it will be added into the v2.0 branch - can you rebase your changes off that branch when you get a chance, please

@KAZYPinkSaurus
Copy link
Author

i will recreate new PR created from 2.0 branch. 🙏
please review it again if you have a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typographical error: 'interupt' should be Corrected to 'interrupt'.
6 participants