Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MTLS support for LB controller #350

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

LeoSpyke
Copy link
Contributor

@LeoSpyke LeoSpyke commented Feb 1, 2024

What does this PR do?

Adds the elasticloadbalancing:DescribeTrustStores IAM policy for the new mTLS feature in LB Controller introduced in v2.7.0.

  • [] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

@LeoSpyke LeoSpyke requested a review from a team as a code owner February 1, 2024 15:25
@LeoSpyke LeoSpyke changed the title feat: mTLS support for LB controller feat: MTLS support for LB controller Feb 1, 2024
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeoSpyke thanks for the PR! We will need a bump of the AWS Load Balancer Controller to version 2.7.0 for mTLS to work. This chart is not yet made available on the eks-charts helm repo.

@LeoSpyke
Copy link
Contributor Author

LeoSpyke commented Feb 2, 2024

@LeoSpyke thanks for the PR! We will need a bump of the AWS Load Balancer Controller to version 2.7.0 for mTLS to work. This chart is not yet made available on the eks-charts helm repo.

https://github.com/aws/eks-charts/releases/tag/v0.0.162

Add IAM policy for the new mTLS feature in LB Controller
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit c875080 into aws-ia:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants