Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reference to optional parameter var.cert_manager.wait #355

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

MartinoMensio
Copy link
Contributor

@MartinoMensio MartinoMensio commented Feb 9, 2024

relates to #354

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@MartinoMensio MartinoMensio requested a review from a team as a code owner February 9, 2024 13:19
@MartinoMensio MartinoMensio changed the title fix reference to optional parameter var.cert_manager.wait fix: reference to optional parameter var.cert_manager.wait Feb 9, 2024
@MartinoMensio MartinoMensio changed the title fix: reference to optional parameter var.cert_manager.wait fix: Reference to optional parameter var.cert_manager.wait Feb 9, 2024
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rodrigobersa rodrigobersa merged commit 077b8bc into aws-ia:main Feb 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported attribute: eks_blueprints_addons/main.tf line 3688
2 participants