Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create subnets with resource based hostnames #1455

Open
rothgar opened this issue Feb 24, 2023 · 4 comments
Open

Create subnets with resource based hostnames #1455

rothgar opened this issue Feb 24, 2023 · 4 comments
Labels

Comments

@rothgar
Copy link

rothgar commented Feb 24, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

Subnets created with blueprints should use resource based names for instances. This will allow Kubernetes nodes to have names that reflect their names in ec2 instead of the private IPv4 addresses

More info here https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-naming.html

k get no
NAME                                             STATUS     ROLES    AGE     VERSION
i-09e0ab41a603abb0d.us-east-2.compute.internal   NotReady   <none>   4s      v1.24.10-eks-48e63af
i-0b3c0d675c5010751.us-east-2.compute.internal   NotReady   <none>   4s      v1.24.10-eks-48e63af
ip-192-168-105-197.us-east-2.compute.internal    Ready      <none>   7d20h   v1.24.10-eks-48e63af
ip-192-168-163-0.us-east-2.compute.internal      Ready      <none>   7d20h   v1.24.10-eks-48e63af

Describe the solution you would like

Creating a subnet with blueprints has this option enabled or exposed for customers. Examples should be updated to use this setting.

Describe alternatives you have considered

Changing hostnames in userdata or after the node is provisioned is not as consistent as doing it at the subnet level.

Additional context

This is a fairly new feature via aws/containers-roadmap#1723

@askulkarni2
Copy link
Contributor

Hi @rothgar, for this, first the support needs to be implemented in the VPC module. They are tracking it here. I will leave this issue open and will update our examples when upstream feature is available.

@bryantbiggs
Copy link
Contributor

this will be added in v4 here terraform-aws-modules/terraform-aws-vpc#838

@bryantbiggs
Copy link
Contributor

this is now supported in v4.0.0 of the VPC module

@bryantbiggs
Copy link
Contributor

and this should now be available in EKS awsdocs/amazon-eks-user-guide#722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants