Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OTLPHTTP collector from upstream #105

Closed
wants to merge 2 commits into from

Conversation

pavankrish123
Copy link

Description:

Added otlphttp exporter from upstream. AppDynamics uses this standard exporter to export traces to our backend.

Link to tracking Issue:

ISSUE #104

Testing:

Tested locally with docker-compose and example application

Documentation:

Changed the README.md file to update the standard list of epxorters

@codecov-io
Copy link

Codecov Report

Merging #105 (fdd1163) into main (64d7a62) will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   75.71%   76.05%   +0.34%     
==========================================
  Files           4        4              
  Lines          70       71       +1     
==========================================
+ Hits           53       54       +1     
  Misses          9        9              
  Partials        8        8              
Impacted Files Coverage Δ
pkg/defaultcomponents/defaults.go 73.33% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d7a62...fdd1163. Read the comment docs.

@mxiamxia
Copy link
Member

Hi @pavankrish123, thanks for the contribution on this. Since we want to have integration test covered on each component we claimed to support in our aws otel collector. We're adding the new integ test cases for OTLPHTTP exporter. Once the test is done, we'll merge your code. Thank you in advance.

@pavankrish123
Copy link
Author

Thanks @mxiamxia

@mxiamxia
Copy link
Member

Hi @pavankrish123 , we have merged otlphttp exporter to main branch, it will go with the next release. Thanks.
#124

@mxiamxia mxiamxia closed this Nov 17, 2020
@pavankrish123
Copy link
Author

Thank you @mxiamxia for a quick turn around!

vastin pushed a commit to vastin/aws-otel-collector that referenced this pull request Mar 3, 2021
Add integration testing for traces for SAPM exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants