From a70bcd8e9a7c1b50dafe25462ef263edae83c383 Mon Sep 17 00:00:00 2001 From: heitorlessa Date: Fri, 30 Jul 2021 16:39:19 +0200 Subject: [PATCH] refactor: rename schema_fetcher param --- .../utilities/feature_toggles/feature_flags.py | 8 ++++---- tests/functional/feature_toggles/test_feature_toggles.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/aws_lambda_powertools/utilities/feature_toggles/feature_flags.py b/aws_lambda_powertools/utilities/feature_toggles/feature_flags.py index 36f5d852ce6..e1b9f0b4ef9 100644 --- a/aws_lambda_powertools/utilities/feature_toggles/feature_flags.py +++ b/aws_lambda_powertools/utilities/feature_toggles/feature_flags.py @@ -9,16 +9,16 @@ class FeatureFlags: - def __init__(self, schema_fetcher: StoreProvider): + def __init__(self, store: StoreProvider): """constructor Parameters ---------- - schema_fetcher: StoreProvider + store: StoreProvider A schema JSON fetcher, can be AWS AppConfig, Hashicorp Consul etc. """ self._logger = logger - self._schema_fetcher = schema_fetcher + self._store = store self._schema_validator = schema.SchemaValidator(self._logger) def _match_by_action(self, action: str, condition_value: Any, context_value: Any) -> bool: @@ -98,7 +98,7 @@ def get_configuration(self) -> Dict[str, Any]: parsed JSON dictionary """ # parse result conf as JSON, keep in cache for self.max_age seconds - config = self._schema_fetcher.get_json_configuration() + config = self._store.get_json_configuration() # validate schema self._schema_validator.validate_json_schema(config) return config diff --git a/tests/functional/feature_toggles/test_feature_toggles.py b/tests/functional/feature_toggles/test_feature_toggles.py index 45b2485190e..4eb4005b9ef 100644 --- a/tests/functional/feature_toggles/test_feature_toggles.py +++ b/tests/functional/feature_toggles/test_feature_toggles.py @@ -26,7 +26,7 @@ def init_configuration_store(mocker, mock_schema: Dict, config: Config) -> Featu cache_seconds=600, config=config, ) - conf_store: FeatureFlags = FeatureFlags(schema_fetcher=app_conf_fetcher) + conf_store: FeatureFlags = FeatureFlags(store=app_conf_fetcher) return conf_store