Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to DynamoDB Stream Event AttribubuteValue to return the proper type for that AttribubuteValue #461

Closed
gwlester opened this issue Jun 5, 2021 · 6 comments
Labels
feature-request feature request
Milestone

Comments

@gwlester
Copy link
Contributor

gwlester commented Jun 5, 2021

Is your feature request related to a problem? Please describe.

When attempting to transverse a DynamoDB Stream Event, it would be nice to know the datatype of an AttributeValue so the correct call to get the value could be made. I.E. string vs list vs map.

Describe the solution you'd like

Add an AtributeValue method that would return the type of value for that attribute. It would be also nice to have enumerated labels for the types.

Describe alternatives you've considered

We always get all three and test the class.

Additional context

@gwlester gwlester added feature-request feature request triage Pending triage from maintainers labels Jun 5, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 5, 2021

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@michaelbrewer
Copy link
Contributor

@gwlester I have a PR for this #462.

Can you check if this is what you want.

@gwlester
Copy link
Contributor Author

gwlester commented Jun 8, 2021

Since the PR got merged -- should this issue be closed now?

Just asking,

@michaelbrewer
Copy link
Contributor

@gwlester kind of, us to you ;-). Once it is deployed, maybe you can help validate that it works for you.

@gwlester
Copy link
Contributor Author

gwlester commented Jun 8, 2021

@michaelbrewer -- let me know when 1.17.0 is available to deploy! Thanks again!!!

@heitorlessa heitorlessa added area/utilities and removed triage Pending triage from maintainers labels Jun 8, 2021
@heitorlessa heitorlessa added this to the 1.17.0 milestone Jun 8, 2021
@heitorlessa
Copy link
Contributor

hey @gwlester this is now available! Added an example in the release notes as well as the docs: https://github.com/awslabs/aws-lambda-powertools-python/releases/tag/v1.17.0

Closing this now as it's already available in PyPi too :)

Thanks a lot @michaelbrewer for the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
None yet
Development

No branches or pull requests

3 participants