Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseProxyEvent: This should draw from self.decoded_body() #544

Closed
whardier opened this issue Jul 20, 2021 · 4 comments
Closed

BaseProxyEvent: This should draw from self.decoded_body() #544

whardier opened this issue Jul 20, 2021 · 4 comments
Labels
feature-request feature request
Milestone

Comments

@whardier
Copy link
Contributor

It seems as though .json_body() would also attempt to decode the body of a proxyevent if the body is marked as base64 encoded.

https://github.com/awslabs/aws-lambda-powertools-python/blob/cb0d54bc36513961422fdebd5953bc11453b4651/aws_lambda_powertools/utilities/data_classes/common.py#L68

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2021

Thanks for opening your first issue here! We'll come back to you as soon as we can.

@michaelbrewer
Copy link
Contributor

@whardier i have a patch for that. Going to add an example test case to

@heitorlessa
Copy link
Contributor

Thanks @michaelbrewer and thanks @whardier for raising it.

@whardier we'd appreciate if you use the issue templates we have available next time you open an issue.

Tagging this for 1.19.0 in early August

@heitorlessa heitorlessa added feature-request feature request pending-release Fix or implementation already in dev waiting to be released labels Jul 26, 2021
@heitorlessa heitorlessa added this to the 1.19.0 milestone Jul 26, 2021
@heitorlessa heitorlessa removed the pending-release Fix or implementation already in dev waiting to be released label Aug 11, 2021
@heitorlessa
Copy link
Contributor

Now released as part of 1.19.0: https://github.com/awslabs/aws-lambda-powertools-python/releases/tag/v1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request feature request
Projects
None yet
Development

No branches or pull requests

3 participants