-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracer): capture method throws errors correctly #1016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 84%↑
🤖 This report was automatically generated by pkg-size-action |
ijemmy
suggested changes
Jul 13, 2022
📊 Package size report -50.9%↓
🤖 This report was automatically generated by pkg-size-action |
saragerion
approved these changes
Jul 13, 2022
ijemmy
approved these changes
Jul 13, 2022
dreamorosi
added a commit
that referenced
this pull request
Aug 2, 2022
* wip * wip * fix: captureMethod now throws * chore: removed leftover comment
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As reported by @saragerion, the Tracer method
captureMethod
was incorrectly catching errors thrown within the body/scope of a decorated Class method defined by users. This is not a desired behaviour as the utility should not catch customers' errors but should simply run the logic defined in the decorator function and then throw the error along for customers to handle/throw in their code.We had this behaviour on the radar as shown by the
TODO
comment present in that part of the code (see diff) but up until now we hadn't noticed / it wasn't reported. Additionally this same change was made to thecaptureLambdaHandler
at some point in the past.This PR modifies the logic of the
captureMethod
decorator and updates the unit tests related to it so that they actually test a method that throws.How to verify this change
See updated unit tests.
Related issues, RFCs
N/A
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.