-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters): add support for custom AWS SDK v3 clients for providers #1260
feat(parameters): add support for custom AWS SDK v3 clients for providers #1260
Conversation
Hey @dreamorosi 👋 I have a couple of things to discuss: To make The constructor method is getting messy, if it's ok we can leave it as is, or we can make something like in other packages with In tests, I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shdq for working on this one, appreciate it!
I like the solution you have proposed with the interfaces, so let's go with it.
Regarding the setOptions
method, I'd leave things as they are and prioritize the other items missing on the utility. However I agree with you, so if we make any further addition/change to the constructor, let's also extract the logic in its own method.
This PR is intended to add support for custom AWS SDK v3 clients for
providers
Providers covered:
AppConfigProvider
DynamoDBProvider
SecretsProvider
SSMProvider
Description of your changes
How to verify this change
Related issues, RFCs
Issue number: #1222
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.