Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: add canary step to layer workflows #1355

Closed
1 of 2 tasks
am29d opened this issue Mar 7, 2023 · 2 comments · Fixed by #1593
Closed
1 of 2 tasks

Maintenance: add canary step to layer workflows #1355

am29d opened this issue Mar 7, 2023 · 2 comments · Fixed by #1593
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline

Comments

@am29d
Copy link
Contributor

am29d commented Mar 7, 2023

Summary

During the current layer distribution we run e2e tests before deploying the layer. This gives us confidence that layer deployment will work. However, after we deploy a public layer we do not run canary tests to test this specific layer. Thus, we should add a canary step to our workflow, similar what powertools python have, so we can catch any layer deployment issues during a release.

Why is this needed?

There is a chance that the public layer we have distributed does not work, and we have no mechanism right now to catch this problems.

Which area does this relate to?

No response

Solution

Add a canary stack, see canary_stack from powertools python, that adds the deployed public layer and runs a lambda function using powertools. We should roll out canary deployment after beta and prod deployments in our layer workflow.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@am29d am29d added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Mar 7, 2023
@dreamorosi dreamorosi added automation This item relates to automation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Mar 7, 2023
@dreamorosi dreamorosi changed the title Maintenance(layers): add canary step to layer workflows Maintenance: add canary step to layer workflows Mar 10, 2023
@am29d am29d added the layers Items related to the Lambda Layers pipeline label Jul 3, 2023
@am29d am29d self-assigned this Jul 10, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jul 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

This is now released under v1.11.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline
Projects
Development

Successfully merging a pull request may close this issue.

2 participants