Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parameters): return type when options without transform is used #1671

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As discussed in the linked issue, when using the Parameters providers to retrieve values from Secrets Manager or DynamoDB and passing an options object with no transform setting, the return type of the value was mistakenly assigned to undefined rather than the default return type for that provider.

This PR fixes the issue by accounting for this case.

Related issues, RFCs

Issue number: #1670

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Sep 4, 2023
@dreamorosi dreamorosi requested a review from a team as a code owner September 4, 2023 16:57
@boring-cyborg boring-cyborg bot added the parameters This item relates to the Parameters Utility label Sep 4, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the bug Something isn't working label Sep 4, 2023
@dreamorosi dreamorosi merged commit b2fe341 into main Sep 4, 2023
12 checks passed
@dreamorosi dreamorosi deleted the 1670-bug-secrets-manager-dynamodb-providers-incorrect-undefined-return-type branch September 4, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parameters This item relates to the Parameters Utility size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Secrets Manager & DynamoDB providers incorrect undefined return type
1 participant