Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(batch): rename AsyncBatchProcessor to default BatchProcessor #1683

Merged
merged 4 commits into from
Sep 18, 2023
Merged

feat(batch): rename AsyncBatchProcessor to default BatchProcessor #1683

merged 4 commits into from
Sep 18, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Sep 14, 2023

Description of your changes

This PR renames AsyncBatchProcessor to BatchProcessor and BatchProcessor to BatchProcessorSync.

Related issues, RFCs

Issue number: closes #1677

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d self-assigned this Sep 14, 2023
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels Sep 14, 2023
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Sep 14, 2023
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Sep 14, 2023
@am29d am29d marked this pull request as ready for review September 18, 2023 09:06
@am29d am29d requested a review from a team as a code owner September 18, 2023 09:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@am29d am29d merged commit e253755 into main Sep 18, 2023
10 checks passed
@am29d am29d deleted the 1677-batch-async-default branch September 18, 2023 11:46
@dreamorosi
Copy link
Contributor

Thanks for the work on this one!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@am29d am29d

Labels
batch This item relates to the Batch Processing Utility documentation Improvements or additions to documentation feature PRs that introduce new features or minor changes internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: make async batch processor default one
2 participants
@am29d @dreamorosi