-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): add idempotency decorator #1723
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR, Alex!
I've left a few comments on the docs only. The general feedback would be to: 1/ let's try to start using import type { fooBar } from '...';
when importing types. This helps with telling TS what we are importing.
Thanks for running the integration tests, they are passing 🎉 |
This reverts commit d138673.
Description of your changes
This PR adds
@idempotent
decorator to the utility. We initially implemented it, but removed later due to uncertainty about decorator interface with TypeScript 5.x upgrade. Now we can restore and simplify the old implementation, by internally callingmakeIdempotent
, making it syntactic sugar for this functionality. This also means that most of e2e tests are very similar to themakeIdempotent
tests, but we still need to make sure that it works when wrapping around decorator.Related issues, RFCs
Issue number: closes #1700
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.