Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): reintroduce token to checkout repo in release workflow #848

Merged
merged 1 commit into from
May 11, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented May 10, 2022

Description of your changes

Currently the on-release workflow is failing due to the following error:

remote: error: GH006: Protected branch update failed for refs/heads/main.        
remote: error: At least 2 approving reviews are required by reviewers with write access.

After a bit of research it appears that this is happening because the workflow is being executed with an identity that doesn't have enough rights to merge onto main, which is a protected branch.

As a part of #805 I removed the token as I didn't know the impact it would have. At the same time we haven't noticed since because we haven't made any release in the past few weeks.

This pr reintroduces the token into the workflow, as well as adding a comment that documents why it's there.

Resources:

How to verify this change

AFAIK the only reasonably straightforward way to verify this PR is to merge it & try to execute the modified workflow.

Related issues, RFCs

#805

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels May 10, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone May 10, 2022
@dreamorosi dreamorosi self-assigned this May 10, 2022
@github-actions github-actions bot added the bug Something isn't working label May 10, 2022
@flochaz flochaz merged commit cabef3e into main May 11, 2022
@flochaz flochaz deleted the fix/add_token_to_release_workflow branch May 11, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants