Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: add e2e test for clear state functionality #924

Closed
saragerion opened this issue May 27, 2022 · 2 comments
Closed

Maintenance: add e2e test for clear state functionality #924

saragerion opened this issue May 27, 2022 · 2 comments
Assignees
Labels
completed This item is complete and has been merged/shipped logger This item relates to the Logger Utility tests PRs that add or change tests

Comments

@saragerion
Copy link
Contributor

Description of the feature request

Problem statement

PR #902 introduces a new flag that developers can enable to "clear the state" across invocations.
If developers want to make sure that persistent attributes added inside the handler function code are not persisted across invocations, they can now set the parameter clearState as true in the injectLambdaContext middleware or decorator.

To further validate that the functionality works as expected, we'd need one or more E2E tests scenarios for the Logger utility that confirm that with the flag enabled, persistent attributes added inside the Lambda function handler are not cached between invocations.

Summary of the feature

Add E2E test scenario for the clear state functionality.

Code examples

N/A

Benefits for you and the wider AWS community

Improved confidence over this feature's effectiveness.

Describe alternatives you've considered

N/A

Additional context

N/A

Related issues, RFCs

#482
#902

@saragerion saragerion added the triage This item has not been triaged by a maintainer, please wait label May 27, 2022
@saragerion
Copy link
Contributor Author

Closing as this is done here
#902

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added logger This item relates to the Logger Utility and removed triage This item has not been triaged by a maintainer, please wait labels Oct 19, 2022
@dreamorosi dreamorosi changed the title Tests (logger): add e2e test for clear state functionality Maintenance: add e2e test for clear state functionality Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
@dreamorosi dreamorosi added the tests PRs that add or change tests label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped logger This item relates to the Logger Utility tests PRs that add or change tests
Projects
None yet
Development

No branches or pull requests

2 participants