Changes to be committed: #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: config/framefetcher-params.json Reduced default URL expiration period to comply w/ SigV4 standards modified: lambda/framefetcher/framefetcher.py Added botoclient Config library Modified s3 client initialization to use SigV4 signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 58
Description of changes:.
There were two files that were modified to ensure that the proper SigV4 S3 presigned urls can be generated.
modified: config/framefetcher-params.json
Reduced default URL expiration period to comply w/ SigV4 standards
modified: lambda/framefetcher/framefetcher.py
Added botoclient Config library
Modified s3 client initialization to use SigV4 signature
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.