fix: correct creation of config.json #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigadsoleiman
approved these changes
Sep 29, 2023
bigadsoleiman
added a commit
that referenced
this pull request
Oct 3, 2023
…ard (#77) * Update README.md * Update README.md * Update README.md * Update config.ts fix: default config without rag engines * Updated time-out * Fix typo * Container versions updated * Container version * Fix issues with Bedrock models and better error messages * fix: correct creation of config.json (#66) * Bedrock permissions for file upload * Readme update (#71) * Update README.md * Update README.md Fix: typo * Update README.md Fix: add note on EULA * run_id support * Update README.md Add 3P models instructions * Additional permissions * Updated 'getName' naming pattern requirements * Add maxLength parameter * Correct metric for OpenSearch vector search * fix: remember kendra indices and optional embeddings --------- Co-authored-by: Sergey Pugachev <pugachev@amazon.com> Co-authored-by: Bigad Soleiman <bigadsoleiman@gmail.com> Co-authored-by: quinngt <qgrasteit@gmail.com>
lloydclowes
pushed a commit
to lloydclowes/gen-ai-playground
that referenced
this pull request
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #65
Description of changes:
The current code was creating an extra level in the configuration dictionary. The fix correctly creates the configuration file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.