Conformitron with cost optimizations #176
Conversation
My branch
There was a problem hiding this comment.
@Howlla Great work, almost near to finish line. Have some feedback.
- Documentation should be improved for completeness. Overview should be added, delete instructions, screenshots of working environment etc etc to be added.
- Lets not have separate instructions for Cost Optimization documentation. Have this in single document. Think about someone want to replicate the entire setup using your documentation. Lets have complete setup instructions.
cdk.jsonshould not have sensitive info.
Appreciate if you can fix this, once done, can review again.
lib/multi-cluster-construct/CostOptimizationSSM/ScaleUpEKStoOne.YAML
Outdated
Show resolved
Hide resolved
|
@Howlla Could you please bring this PR to closure. Its long pending. |
There was a problem hiding this comment.
@Howlla great work and much needed pattern. Please see some comments I left. It would be nice to test it out with 1.15.0 blueprints that we released last week.
There was a problem hiding this comment.
Overall, everything now LGTM. @shapirov103 Please share if all your comments are fixed and let me know. I can check once again and do merge.
There was a problem hiding this comment.
There are some minor things to improve on the doc side, like making sure you use dots at the end of the sentences, and proper casing, some spelling errors like seperate should be separate, vpc should be VPC, and such. I am willing to defer these, there is always space to improve. Please check some pending comments from Ela, like instructions to delete, which may cause some issue with ArgoCD resource being orphaned. We should be explicit about it, if there is some manual effort and gotchas, we can call them out.
There was a problem hiding this comment.
LGTM. @Howlla This is bar raising work, im good to merge this. Hope you can support the pattern in continuous basis for ongoing issues with Conformitron.
Issue #, if available:
Description of changes: Code for conformitron mult-cluster deployment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.