-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python is dependency is out of date #7
Comments
Related, I'm coming at this from Terraform, new to CDK. This confused me as well: |
Hi! Thanks for reporting this! Looks like latest cdk-nag is picking up errors I didn't get before on the new Lambda runtimes. You can bypass the cdk-nag for now to get past this error and I will fix the root cause soon. Just comment out these lines in the
And do the same for |
This was easy enough to work around. I'm in the process of making a bunch of changes to login_with_steam.py and will include updating the Python dependency with that PR. |
I also added a temporary suppression for that Lambda warning (it's expecting Python 3.11 and we are using 3.10). I'll update the libraries to enable 3.11 support later. I think you have a newer cdk-nag than the one defined for the CDK app which caused this. And thanks for the heads up on PR, great to get community support for this! |
I have Python 3.11 working, I had to update the pip platform from manylinux2010_x86_64 to manylinux2014_x86_64. Without this, a very old version of pyjwt is pulled in due to an ffi dependency. The old version of pyjwt had a line that's incompatible with 3.11 and likely has other issues as well. |
PR: Still hooking up my Steam test harness, once I have that in place will have another pull request based on lessons learned from a live deployment very similar to this stack. |
Closed prior PR due to it pulling in other changes that blew up scope. new PR: |
Thank you! Now fixed after merging the pull request above |
Following the install instructions ran into this after running:
cdk synth --profile brianmorin
Probably a simple fix, but leaving a tracking issue here.
The text was updated successfully, but these errors were encountered: