Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output-validate doesnt support non-root file paths #61

Closed
tsirlucas opened this issue Feb 26, 2020 · 3 comments
Closed

output-validate doesnt support non-root file paths #61

tsirlucas opened this issue Feb 26, 2020 · 3 comments

Comments

@tsirlucas
Copy link

tsirlucas commented Feb 26, 2020

How to reproduce

If you're using the Source Metadata Option triggers and passing a bucket folder on destBucket.

Ex:

  {
    srcVideo: any,
    destBucket: `${environment.assetsBucket}/folder1/folder2`
  };

Reason

I believe the reason is the buildUrl function, which is ignoring everything after the 3rd item when calling splice. In the past example, all urls would be incomplete because we would have more items.

Test case

I have create this fork with a test case and a fix for the problem. I would gladly create a PR. Just need to confirm if there is any reason why the buildUrl function is ignoring everything after the 3rd item.

@dscpinheiro
Copy link

Hi @tsirlucas,

Thanks for the contribution!
If you create a PR, we'll look at including it in the next release of the solution.

@tsirlucas
Copy link
Author

For some reason I'm receiving a 500 when trying to create the PR. I'm actually receiving a 500 just by accessing https://github.com/awslabs/video-on-demand-on-aws/compare. I'll try again in a few hours.

@tomnight
Copy link
Contributor

tomnight commented May 4, 2020

This issue was fixed in the latest release v5.1.0

@aassadza aassadza closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants