Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating helm to support windows #75

Merged
merged 3 commits into from
Jul 23, 2020
Merged

updating helm to support windows #75

merged 3 commits into from
Jul 23, 2020

Conversation

brycahta
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • updates to helm daemonsets, values, and helper to support Windows

Testing:

  • setup eks cluster with linux and windows nodes
  • built and uploaded aemm Windows image to a "test" dockerhub repo
  • used my local workspace as the aemm download path for NTH e2e tests
  • AEMM pod runs on Windows node successfully
  • all NTH e2e tests pass on Windows node using AEMM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brycahta brycahta requested review from pdk27 and cjerad July 21, 2020 23:37
Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

helm/amazon-ec2-metadata-mock/templates/_helpers.tpl Outdated Show resolved Hide resolved
@brycahta
Copy link
Contributor Author

brycahta commented Jul 22, 2020

Updates from latest push:

  • addressed PR comments
  • updating upload-resources-to-github to check for existence before adding to list of artifacts to upload
    • needed for Windows
  • added Windows binary + image build to travis
  • added Windows deployments to travis

Testing:

sent from my not-a-windows machine

Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@brycahta brycahta merged commit 9cdd9e9 into aws:master Jul 23, 2020
@brycahta brycahta deleted the windows-supp branch July 23, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants