Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate 'create' timeout #214

Closed
euank opened this issue Sep 29, 2015 · 1 comment
Closed

Reevaluate 'create' timeout #214

euank opened this issue Sep 29, 2015 · 1 comment

Comments

@euank
Copy link
Contributor

euank commented Sep 29, 2015

Currently the timeout the Agent enforces for docker create is 1 minute.

For the below reasons, we should collect some data and reconsider this timeout.

When under unusually heavy load, Docker's create times increase drastically, including well past that timeout. I've also got an issue on their end: moby/moby#15802

It's possible that this timeout could also be brushed against in more normal operation however. This forum post shows an instance of create taking ~70 seconds in normal operation while using an older version of Docker (1.6.2 I think).

Other possible resolutions to this, other than picking a bigger number, include throttling calls to Docker's API. One particularly good approach here could be to observe create times and backoff proportional to their increase, though that won't be trivial to implement.

@samuelkarp
Copy link
Contributor

This should have been closed with our v1.6.0 release. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants