-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os-type change breaks backward compatibility #2881
Comments
@HaroonSaid thanks for reporting this issue, looking into it. |
Thanks for raising this @HaroonSaid - we are having the exact same problem. Our environment is: Just for reference, the docs are still referring to the "linux" and "windows" values so I assume this could be a bug in the agent (?)
Thanks for looking into this @shubham2892 |
I was able to reproduce this issue, working on the fix. |
related PR: #2859 |
Thanks a lot for reporting the issue @HaroonSaid @swlasse. While we're working on the fix and a new agent release for the same, could you please try modifying the placement constraints in your task definition to -
changing to |
Thanks for the update @singholt. I assume you are going back to how the original |
Hi @swlasse, we're currently evaluating our options and we do plan to ensure that whatever changes come in do not break backward compatibility again. We'll keep this issue updated, thanks! |
Sounds good @singholt. Thanks a lot for the update 👍 |
The approach we did as a solution
We have a custom attribute |
I think creating a new attribute would have been easier and simpler |
Yes, I agree. In order to resolve this issue we have created our own custom attribute with os-family info - similar to your approach @HaroonSaid. |
Just an FYI, the change had a much bigger impact on the stable production environments as new EC2 instances came alive with new agents - scaling up the ECS tasks failed to start. |
Closing as the code generating the issue was reverted in v1.53.0 |
Thanks for looking into this @angelcar and team. Do you know when a new ECS Optimized Windows Server Core 2004 AMI with the 1.53.0 agent will be available? The SSM parameter: |
Hi @swlasse, AMI release is in progress and should be out soon. I'll let you know here once its available. |
ECS Windows AMIs with updated agent are now public. Please let us know if you need anything else. Thanks |
Thanks @singholt - I've have just tried it out and things are now working as expected (new Windows AMI is available with the new 1.53.0 ECS agent and the value of the |
Summary
We run mixed-mode instances in our ECS clusters with windows (2016,2019 and 20H2) and Linux
Prior to Agent 1.51.1, the os-type for windows instances was
windows
, and on deployment, the task with a placement constraint worked perfectlyThe new names,
WINDOWS_SERVER_XXXX_FULL|CORE
break backward compatibilitye.g.
WINDOWS_SERVER_2004_CORE
orWINDOWS_SERVER_20H2_CORE
We also use custom attributes code to determine placement
The changes in 1.15.1 breaks compatibility
Description
Expected Behavior
Observed Behavior
Environment Details
Supporting Log Snippets
The text was updated successfully, but these errors were encountered: