Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-agent deletes ecs-service-connect-agent:interface-v1 when ECS_ENABLE_UNTRACKED_IMAGE_CLEANUP=true #3520

Closed
andrewradamis-paay opened this issue Dec 14, 2022 · 2 comments
Labels

Comments

@andrewradamis-paay
Copy link

Summary

If ECS_ENABLED_UNTRACKED_IMAGE_CLEANUP is set to true, the ecs-agent will remove the ecs-service-connect-agent:interface-v1 image and tasks enabled for Service Connect will fail to start.

Description

If ECS_ENABLED_UNTRACKED_IMAGE_CLEANUP is set to true, the ecs-agent will remove the ecs-service-connect-agent:interface-v1 image and tasks enabled for Service Connect will fail to start.
Adding ECS_EXCLUDE_UNTRACKED_IMAGE=ecs-service-connect-agent:interface-v1 to ecs.config is a work-around for the issue.
I'm not familar with the ecs-agent codebase, but I'm guessing it just needs to be added to

excludedImages := append(cfg.ImageCleanupExclusionList,
cfg.PauseContainerImageName+":"+cfg.PauseContainerTag,
config.DefaultPauseContainerImageName+":"+config.DefaultPauseContainerTag,
config.CachedImageNameAgentContainer,
)
.

Expected Behavior

Don't delete ecs-service-connect-agent:interface-v1

Observed Behavior

ecs-agent deleted ecs-service-connect-agent:interface-v1 then failed to start a Service Connect Task with error CannotCreateContainerError: Error response from daemon: No such image: ecs-service-connect-agent:interface-v1.

Environment Details

Using ami-028cbf4835af1ad6f (amzn2-ami-ecs-hvm-2.0.20221207-x86_64-ebs)

Supporting Log Snippets

@ubhattacharjya
Copy link
Contributor

Hi @andrewradamis-paay,

Thank you for reporting the issue. We will provide an update on this soon.

Utsa

@mythri-garaga
Copy link
Contributor

mythri-garaga commented Jan 17, 2023

Issue has been fixed in 1.68.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants