Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory limit not enforced on Windows #616

Closed
samuelkarp opened this issue Nov 30, 2016 · 1 comment
Closed

Memory limit not enforced on Windows #616

samuelkarp opened this issue Nov 30, 2016 · 1 comment
Labels
os/windows scope/ECS Agent
Milestone
1.16.0

Comments

@samuelkarp
Copy link
Contributor

Containers on Windows are showing up with "Memory": 0 even when a memory limit is configured in the task definition. This appears to be related to the Memory field moving from Config to HostConfig in API version 1.18.

On Linux, compatibility is maintained through reading from both Config fields and HostConfig, but Windows omits that code. See a 1.17 example versus a 1.19 example to see how the field moved.

This is related to other API compatibility issues as noted in moby/moby#27601.
@richardpen richardpen mentioned this issue Nov 10, 2017
Merged
9 tasks
@samuelkarp samuelkarp added this to the 1.16.0 milestone Nov 22, 2017
@samuelkarp
Copy link
Contributor Author

We've released version 1.16.0 of the ECS agent and a new ECS-optimized Windows AMI that supports memory limits. Please note that Windows containers have a higher minimum memory requirement than Linux containers. See the updated documentation for instructions to get started using the new AMI.

@samuelkarp samuelkarp mentioned this issue Dec 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os/windows scope/ECS Agent
Projects
None yet
Milestone
1.16.0
Development

No branches or pull requests
2 participants
@samuelkarp @aaithal