Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eks.amazonaws.com/include-containers annotation #147

Open
rittneje opened this issue Mar 15, 2022 · 1 comment
Open

Add eks.amazonaws.com/include-containers annotation #147

rittneje opened this issue Mar 15, 2022 · 1 comment

Comments

@rittneje
Copy link

What would you like to be added:

Add support for a eks.amazonaws.com/include-containers. It is a comma-separated list of container names into which the token and env vars will be injected. Other containers will not be modified. If specified, then eks.amazonaws.com/skip-containers is ignored.

Why is this needed:

Building up a negative list for eks.amazonaws.com/skip-containers is cumbersome, as we have to account for all sidecars being injected by other webhooks. Typically we only have one "main" container that needs the credentials, so it would be a lot simpler to just put its name.

@james-callahan
Copy link
Contributor

This would be awesome as a label to use with the webhook for objectSelector: it would mean a way to opt-in pods to the webhook, possibly with a failurePolicy: Fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants