Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random token mount path #157

Open
jeremydonahue opened this issue Jul 5, 2022 · 0 comments
Open

Random token mount path #157

jeremydonahue opened this issue Jul 5, 2022 · 0 comments

Comments

@jeremydonahue
Copy link

jeremydonahue commented Jul 5, 2022

What would you like to be added:

Currently, the webhook uses the value of --token-mount-path (default /var/run/secrets/eks.amazonaws.com/serviceaccount/token) to determine where inside the pod the token file should be mounted.

Instead, I would like the ability for the path to the token file to contain a random element (eg. /var/run/secrets/eks.amazonaws.com/serviceaccount/token-<uuid>).

Why is this needed:

To prevent Local File Inclusion attacks. If an attacker knows where the file is and has gained the ability to read files from disk, they can read the token file and potentially assume a role that trusts the service account. If the path is random then they can't do that.


I'm checking to see if you would be willing to accept a PR for this feature. If so, I would be happy to submit one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant