You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be enhanced:
The controller shouldn't requeue pods which are not found. Not found will remain as not-found till cache updates and requeue them.
The similar improvement in controller runtime can be referenced at kubernetes-sigs/controller-runtime#377
{"level":"error","timestamp":"2022-09-13T18:23:20.282Z","logger":"vpc.amazonaws.com/pod-eni-worker","msg":"re-queuing job","job":{"Operation":"Create","UID":"","PodName":"hello-world-7c4b75bf8c-tzzp8","PodNamespace":"default","RequestCount":1,"NodeName":""},"retry count":1,"error":"failed to find pod default/hello-world-7c4b75bf8c-tzzp8","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:154\ngit.luolix.top/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"error","timestamp":"2022-09-13T18:24:19.143Z","logger":"vpc.amazonaws.com/pod-eni-worker","msg":"re-queuing job","job":{"Operation":"Create","UID":"","PodName":"hello-world-7c4b75bf8c-tzzp8","PodNamespace":"default","RequestCount":1,"NodeName":""},"retry count":3,"error":"failed to find pod default/hello-world-7c4b75bf8c-tzzp8","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:154\ngit.luolix.top/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"error","timestamp":"2022-09-13T18:25:09.442Z","logger":"vpc.amazonaws.com/pod-eni-worker","msg":"re-queuing job","job":{"Operation":"Create","UID":"","PodName":"hello-world-7c4b75bf8c-tzzp8","PodNamespace":"default","RequestCount":1,"NodeName":""},"retry count":4,"error":"failed to find pod default/hello-world-7c4b75bf8c-tzzp8","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:154\ngit.luolix.top/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
{"level":"error","timestamp":"2022-09-13T18:25:59.743Z","logger":"vpc.amazonaws.com/pod-eni-worker","msg":"exceeded maximum retries","job":{"Operation":"Create","UID":"","PodName":"hello-world-7c4b75bf8c-tzzp8","PodNamespace":"default","RequestCount":1,"NodeName":""},"max retries":5,"error":"failed to find pod default/hello-world-7c4b75bf8c-tzzp8","stacktrace":"github.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).processNextItem\n\t/workspace/pkg/worker/worker.go:149\ngit.luolix.top/aws/amazon-vpc-resource-controller-k8s/pkg/worker.(*worker).runWorker\n\t/workspace/pkg/worker/worker.go:132"}
Why is the change needed and what use case will it solve:
This behavior will add deleted pods into queue till reaching the max retry. In large and high churning rate cluster, this can worsen queue performance unnecessarily.
The text was updated successfully, but these errors were encountered:
What would you like to be enhanced:
The controller shouldn't requeue pods which are not found. Not found will remain as not-found till cache updates and requeue them.
The similar improvement in controller runtime can be referenced at kubernetes-sigs/controller-runtime#377
Why is the change needed and what use case will it solve:
This behavior will add deleted pods into queue till reaching the max retry. In large and high churning rate cluster, this can worsen queue performance unnecessarily.
The text was updated successfully, but these errors were encountered: