Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CRDs after upgrade #226

Closed
jdn5126 opened this issue May 23, 2023 · 4 comments
Closed

Missing CRDs after upgrade #226

jdn5126 opened this issue May 23, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jdn5126
Copy link
Contributor

jdn5126 commented May 23, 2023

Describe the Bug:
Following VPC Resource Controller upgrade from v1.1.4 to v1.1.5, SecurityGroupPolicy objects created before the upgrade are returning as not found by the annotation webhook:

Webhook couldn't find SGP definition: GroupVersionResource or GroupKind didn't match. Will allow regular pods creation.

Those objects are present when kubectl get SecurityGroupPolicy -A is run.

Observed Behavior:
Newly created pods are not annotated with the correct branch ENI.

Expected Behavior:
Pods should be annotated based on the SecurityGroupPolicy that they match.

How to reproduce it (as minimally and precisely as possible):
It is not clear how to reproduce this, though the setup seems to require:

  1. VPC RC v1.1.4 and SecurityGroupPolicy objects to exist
  2. VPC RC upgrade

Additional Context:

Environment: EKS 1.24

  • Kubernetes version (use kubectl version): v1.24
  • CNI Version - v1.12.6
  • OS (Linux/Windows): Linux
@jdn5126 jdn5126 added the bug Something isn't working label May 23, 2023
@hitsub2
Copy link

hitsub2 commented May 24, 2023

If we upgrade EKS control plane from 1.24 to 1.25, the vpc resource controller will also be upgraded from v1.1.4 to v1.1.5 automatically? Or does AWS sometime upgrade the vpc resource to newer version as needed?

@haouc
Copy link
Contributor

haouc commented Jul 28, 2023

@hitsub2 sorry for a late response. When you update your control plane, the service in control plane will be updated to the latest version. If you don't update, EKS will keep services updated as needed.

@haouc
Copy link
Contributor

haouc commented Jul 28, 2023

This should be a cache missing issue. We are using cached client. We are working on upgrading dependencies to make it more resilient.

@haouc
Copy link
Contributor

haouc commented Jul 28, 2023

Since it is not reproducible, I am closing it for now. Please feel free to reopen for any concern.

@haouc haouc closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants