Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish images for sample applications used in the App Mesh examples walkthroughs #330

Open
fawadkhaliq opened this issue Aug 5, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@fawadkhaliq
Copy link

Description
Currently, every time a user wants to try any of the walkthrough examples in this repo, they need to build the sample application images, publish them to ECR and then use them in their App Mesh setup. This also requires the users to have Docker installed on their machine to build the images.

Proposed change
We should publish images for sample applications used in the App Mesh walkthroughs and by default use the published images. If a user wants to modify the application code or override, they should have the ability to do so.

@fawadkhaliq fawadkhaliq added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 5, 2020
@jlbutler
Copy link
Collaborator

We should consider smaller images as well. It should be fairly easy to drop some bulk on these. I can help with this, later this week @fawadkhaliq.

@fawadkhaliq
Copy link
Author

@jlbutler absolutely! That'd be great if you can help with it. thanks!

@fawadkhaliq
Copy link
Author

@jlbutler assigning the issue to you since you'll be working on it

@jlbutler
Copy link
Collaborator

jlbutler commented Oct 8, 2020

Yep I'm working on this one... in slow motion, apparently. I have been wondering if we should also port the demo app that most of these use to Go for a faster build and smaller image. I will update again soon and get something rolling.

@jlbutler
Copy link
Collaborator

Status update, I'm working through an internal process on releasing these images as artifacts. Once that's complete, I can move on to resolving this.

@jlbutler
Copy link
Collaborator

Another update so the issue doesn't go stale. The process is well defined, but it'll take some refactoring and some legwork in the repo across all of the walkthroughs. I have scheduled time to work on this once I'm through a set of current work and will bring back a proposal PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants