RFC: 171 CloudFront Redesign #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Still in draft state, but hopefully getting closer.
skinny85
reviewed
Jun 27, 2020
iliapolo
reviewed
Jul 6, 2020
rix0rrr
reviewed
Jul 7, 2020
skinny85
reviewed
Jul 9, 2020
iliapolo
reviewed
Jul 9, 2020
iliapolo
reviewed
Jul 9, 2020
rix0rrr
reviewed
Jul 9, 2020
iliapolo
reviewed
Jul 9, 2020
iliapolo
reviewed
Jul 9, 2020
skinny85
approved these changes
Jul 9, 2020
|
I like this design! I'm currently using the cloudfront module and I feel like the existing ergonomics leave tons of room for improvement :) Apologies if this is a naive question, but my understanding is that this is only the RFC - would there be a place where I could track implementation/release of these constructs? Thanks! |
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Jul 16, 2020
See aws/aws-cdk-rfcs#174 for the design that inspired this implementation. The goal of this initial PR is to get the new Distribution construct to the point where it supports the most common use cases, in terms of single- and multi-origin and behaviors with the most common properties exposed and working. This is not intended to be a complete/exhaustive implementation, but does allow for users with S3 buckets to create CloudFront distributions more easily than the existing construct today. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@wcauchois - Thanks for the interest and feedback! We are proceeding forward with the implementation, and using this milestone to track the initial "developer preview" launch: https://github.com/aws/aws-cdk/milestone/5. |
eladb
pushed a commit
that referenced
this pull request
Jul 27, 2020
* RFC: 0171 CloudFront Redesign - initial rough ideas * Iteration #2 of the API, sans the Lambda@Edge functionality. Still in draft state, but hopefully getting closer. * Lambda@Edge API v1, plus some of the open questions and other sections filled in. * Added detailed design section, including before/after examples * Proper namespacing in the examples, and updated the open questions * Minor update to force pull request refresh * Minor changes per feedback; removing the 'draft' tag * Distribution.for* syntactic sugar * Removing Distribution.behavior, keeping origin->behavior nesting consistent * Minor API updates per feedback and lessons learned from implementation * Added implementation note for capturing behavior ordering
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
See aws/aws-cdk-rfcs#174 for the design that inspired this implementation. The goal of this initial PR is to get the new Distribution construct to the point where it supports the most common use cases, in terms of single- and multi-origin and behaviors with the most common properties exposed and working. This is not intended to be a complete/exhaustive implementation, but does allow for users with S3 buckets to create CloudFront distributions more easily than the existing construct today. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: "RFC: #171 CloudFront Redesign"
labels: management/rfc
Proposal to redesign the @aws-cdk/aws-cloudfront module.
The current module does not adhere to the best practice naming conventions or ease-of-use patterns that are present in the other CDK modules. A redesign of the API will allow for friendly, easier access to common patterns and usages.
This RFC does not attempt to lay out the entire API; rather, it focuses on a complete re-write of the module README with a focus on the most common use cases and how they work with the new design. More detailed designs and incremental API improvements will be tracked as part of GitHub Project Board once the RFC is approved.
Rendered version
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license