From 03210be34d7d32572dc3da935b28724e12fc9a5c Mon Sep 17 00:00:00 2001 From: Nicolas Ruiz <60710594+MrSyn88@users.noreply.github.com> Date: Thu, 20 Oct 2022 18:28:28 -0500 Subject: [PATCH] chore(aws-eks): changed instanceType to instanceTypes in addNodegroupCapacity functions (#22590) fixes https://github.com/aws/aws-cdk/issues/22547 --- Since `instanceType` is deprecated, I changed it to `instanceTypes` in all the `addNodegroupCapacity` functions ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts b/packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts index 9d09025b44f61..d33e2ee098404 100644 --- a/packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts +++ b/packages/@aws-cdk/aws-eks/test/integ.eks-cluster.ts @@ -192,7 +192,7 @@ class EksClusterStack extends Stack { private assertNodeGroupX86() { // add a extra nodegroup this.cluster.addNodegroupCapacity('extra-ng', { - instanceType: new ec2.InstanceType('t3.small'), + instanceTypes: [new ec2.InstanceType('t3.small')], minSize: 1, // reusing the default capacity nodegroup instance role when available nodeRole: this.cluster.defaultCapacity ? this.cluster.defaultCapacity.role : undefined, @@ -241,7 +241,7 @@ class EksClusterStack extends Stack { private assertNodeGroupArm() { // add a extra nodegroup this.cluster.addNodegroupCapacity('extra-ng-arm', { - instanceType: new ec2.InstanceType('m6g.medium'), + instanceTypes: [new ec2.InstanceType('m6g.medium')], minSize: 1, // reusing the default capacity nodegroup instance role when available nodeRole: this.cluster.defaultCapacity ? this.cluster.defaultCapacity.role : undefined, @@ -250,7 +250,7 @@ class EksClusterStack extends Stack { private assertNodeGroupGraviton3() { // add a Graviton3 nodegroup this.cluster.addNodegroupCapacity('extra-ng-arm3', { - instanceType: new ec2.InstanceType('c7g.large'), + instanceTypes: [new ec2.InstanceType('c7g.large')], minSize: 1, // reusing the default capacity nodegroup instance role when available nodeRole: this.cluster.defaultCapacity ? this.cluster.defaultCapacity.role : undefined,