Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support docker engine v20.10.0-beta1 #11124

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Oct 26, 2020

Running an image by only providing the hash fails on docker engine v20.10.0-beta1 with invalid repository name.

docker run --rm b92402b29db56f1bbace74c369bedef5ee296a76fd8545426255247da70ce21a
docker: Error response from daemon: invalid repository name (b92402b29db56f1bbace74c369bedef5ee296a76fd8545426255247da70ce21a), cannot specify 64-byte hexadecimal strings.

Using docker run --rm sha256:b92402b29db56f1bbace74c369bedef5ee296a76fd8545426255247da70ce21a instead works as expected.

I haven't been able to pinpoint the exact change yet as this seems not to be mentioned in https://github.com/docker/docker-ce/blob/0fc7084265b3786a5867ec311d3f916af7bf7a23/CHANGELOG.md

Created an issue with docker to clarify whether this is a regression or a planned change docker/cli#2815


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 26, 2020

@SomayaB SomayaB changed the title fix(@aws-sdk/core): support docker engine v20.10.0-beta1 fix(core): support docker engine v20.10.0-beta1 Oct 26, 2020
@johanneswuerbach
Copy link
Contributor Author

Anything I can do to move this forward? Otherwise the CDK is broken on the Docker for Mac Edge channel when you build assets in docker.

@jogold
Copy link
Contributor

jogold commented Oct 29, 2020

@rix0rrr or @eladb can you take a look here? LGTM

johanneswuerbach and others added 2 commits October 29, 2020 13:34
Co-authored-by: Jonathan Goldwasser <jogold@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 20918d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 87887a3 into aws:master Oct 29, 2020
@johanneswuerbach johanneswuerbach deleted the fix-docker-v20.10 branch October 29, 2020 20:12
@sirvio
Copy link

sirvio commented Nov 1, 2020

hmm, seems not to work for me yet. Still receive "invalid repository name ..... cannot specify 64-byte hexadecimal strings" when using docker engine 20.10.0-beta1 for mac and cdk 1.71.0.

@jogold
Copy link
Contributor

jogold commented Nov 2, 2020

hmm, seems not to work for me yet. Still receive "invalid repository name ..... cannot specify 64-byte hexadecimal strings" when using docker engine 20.10.0-beta1 for mac and cdk 1.71.0.

This fix will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants