-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): support docker engine v20.10.0-beta1 #11124
Conversation
4cd614d
to
acf1342
Compare
Anything I can do to move this forward? Otherwise the CDK is broken on the Docker for Mac Edge channel when you build assets in docker. |
Co-authored-by: Jonathan Goldwasser <jogold@users.noreply.github.com>
2bb07f4
to
eb397bd
Compare
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hmm, seems not to work for me yet. Still receive "invalid repository name ..... cannot specify 64-byte hexadecimal strings" when using docker engine 20.10.0-beta1 for mac and cdk 1.71.0. |
This fix will be included in the next release. |
Running an image by only providing the hash fails on docker engine v20.10.0-beta1 with invalid repository name.
Using
docker run --rm sha256:b92402b29db56f1bbace74c369bedef5ee296a76fd8545426255247da70ce21a
instead works as expected.I haven't been able to pinpoint the exact change yet as this seems not to be mentioned in https://github.com/docker/docker-ce/blob/0fc7084265b3786a5867ec311d3f916af7bf7a23/CHANGELOG.md
Created an issue with docker to clarify whether this is a regression or a planned change docker/cli#2815
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license