Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): allow HTTPS connections from LB to task #11381

Merged
merged 3 commits into from
Nov 20, 2020
Merged

feat(ecs): allow HTTPS connections from LB to task #11381

merged 3 commits into from
Nov 20, 2020

Conversation

hoegertn
Copy link
Contributor

@hoegertn hoegertn commented Nov 9, 2020

If you need or want to encrypt traffic between the load balancer and the ECS task you need to set the protocol of the target group to HTTPS. This PR adds a new property to specify this.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 9, 2020

@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Nov 9, 2020
@hoegertn
Copy link
Contributor Author

@iamhopaul123 would you mind taking a look at this?

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM. Thank you for doing this! The only request is could you test this feature manually to make sure it works as expected?

@hoegertn
Copy link
Contributor Author

The Unittest shows that the CFN is created correctly. The setting itself I can confirm as I am running this using overrides for some setups.

@justin-ad
Copy link

I require this functionality as well, looking forward to seeing this merged.

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b1a2756
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants