-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): allow HTTPS connections from LB to task #11381
Conversation
@iamhopaul123 would you mind taking a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM. Thank you for doing this! The only request is could you test this feature manually to make sure it works as expected?
The Unittest shows that the CFN is created correctly. The setting itself I can confirm as I am running this using overrides for some setups. |
I require this functionality as well, looking forward to seeing this merged. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
If you need or want to encrypt traffic between the load balancer and the ECS task you need to set the protocol of the target group to
HTTPS
. This PR adds a new property to specify this.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license