Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applicationautoscaling): Add KAFKA to ServiceNamespace #11394

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

bracki
Copy link
Contributor

@bracki bracki commented Nov 10, 2020

Add KAFKA to ServiceNamespace. This allows targeting MSK's autoscaling feature.

Fixes #11366


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 10, 2020

@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@bracki bracki changed the title Add KAFKA to ServiceNamespace feat: Add KAFKA to ServiceNamespace Nov 10, 2020
@bracki bracki changed the title feat: Add KAFKA to ServiceNamespace feat(applicationautoscaling): Add KAFKA to ServiceNamespace Nov 10, 2020
NetaNir
NetaNir previously approved these changes Nov 10, 2020
@mergify mergify bot dismissed NetaNir’s stale review November 10, 2020 19:41

Pull request has been modified.

@iwt-janbrauer
Copy link

Apparently I have to add something to a README, which doesn't make sense in this case.
Can you take a look @NetaNir? I fixed the other issues.

@NetaNir NetaNir added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 11, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Nov 11, 2020

@Mergifyio refresh

@aws aws deleted a comment from mergify bot Nov 12, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Command update: success

Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 44bf878
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NetaNir NetaNir added the pr-linter/exempt-test The PR linter will not require test changes label Nov 12, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Nov 12, 2020

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Command refresh: success

Pull request refreshed

@NetaNir
Copy link
Contributor

NetaNir commented Nov 12, 2020

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Command update: success

Branch already up to date

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b5c3f84 into aws:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-applicationautoscaling] Add 'kafka' to ServiceNamespace
4 participants